aswinshakil commented on a change in pull request #2745:
URL: https://github.com/apache/ozone/pull/2745#discussion_r731444241
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerImpl.java
##########
@@ -117,6 +117,18 @@ public void addContainerToPipeline(
}
}
+ @Override
+ public void addContainerToPipelineSCMStart(
+ PipelineID pipelineId, ContainerID containerID)
+ throws IOException {
+ lock.writeLock().lock();
Review comment:
This implementation is the same as addContainerToPipeline. I haven't
modified the usage the of lock here. But should we remove the lock here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
