rakeshadr commented on a change in pull request #2751:
URL: https://github.com/apache/ozone/pull/2751#discussion_r733443091
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3815,7 +3815,7 @@ void reloadOMState(long newSnapshotIndex, long
newSnapshotTermIndex)
metrics.setNumBuckets(metadataManager.countRowsInTable(metadataManager
.getBucketTable()));
metrics.setNumKeys(metadataManager.countEstimatedRowsInTable(metadataManager
- .getKeyTable()));
+ .getKeyTable(getBucketLayout())));
Review comment:
@aryangupta1998 , Need to include both FSO and OBS key paths. Presently,
this patch is considering only DEFAULT layout.
```
metrics.setNumKeys(metadataManager.countEstimatedRowsInTable(metadataManager
.getKeyTable(getBucketLayout())));
```
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java
##########
@@ -73,7 +74,8 @@ public FileSizeCountTask(FileCountBySizeDao
fileCountBySizeDao,
*/
@Override
public Pair<String, Boolean> reprocess(OMMetadataManager omMetadataManager) {
- Table<String, OmKeyInfo> omKeyInfoTable = omMetadataManager.getKeyTable();
+ Table<String, OmKeyInfo> omKeyInfoTable =
Review comment:
@aryangupta1998 same comment here as well, we need to include both FSO
and OBS key paths.
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java
##########
@@ -159,8 +160,8 @@ public Response getKeysForContainer(
// Directly calling get() on the Key table instead of iterating since
// only full keys are supported now. When we change to using a prefix
// of the key, this needs to change to prefix seek.
- OmKeyInfo omKeyInfo = omMetadataManager.getKeyTable().getSkipCache(
- containerKeyPrefix.getKeyPrefix());
+ OmKeyInfo omKeyInfo = omMetadataManager.getKeyTable(getBucketLayout())
Review comment:
@aryangupta1998 , Here also need to include both FSO and OBS key paths.
Presently, this patch is considering only DEFAULT layout.
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java
##########
@@ -77,7 +78,8 @@ public ContainerKeyMapperTask(ReconContainerMetadataManager
reconContainerMetadataManager
.reinitWithNewContainerDataFromOm(new HashMap<>());
- Table<String, OmKeyInfo> omKeyInfoTable =
omMetadataManager.getKeyTable();
+ Table<String, OmKeyInfo> omKeyInfoTable =
+ omMetadataManager.getKeyTable(getBucketLayout());
Review comment:
@aryangupta1998 same comment here as well, we need to include both FSO
and OBS key paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
