ayushtkn commented on a change in pull request #2785:
URL: https://github.com/apache/ozone/pull/2785#discussion_r739460063
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -312,7 +312,8 @@ private RaftProperties newRaftProperties() {
StorageUnit.BYTES);
RaftServerConfigKeys.Log.setQueueElementLimit(
properties, logQueueNumElements);
- RaftServerConfigKeys.Log.setQueueByteLimit(properties, logQueueByteLimit);
+ RaftServerConfigKeys.Log.setQueueByteLimit(properties,
+ SizeInBytes.valueOf(logQueueByteLimit));
Review comment:
How does this prevent integer overflow of ``logQueueByteLimit``, This
value is type casted into `(int)` above
```
final int logQueueByteLimit = (int) conf.getStorageSize(
OzoneConfigKeys.DFS_CONTAINER_RATIS_LOG_QUEUE_BYTE_LIMIT,
OzoneConfigKeys.DFS_CONTAINER_RATIS_LOG_QUEUE_BYTE_LIMIT_DEFAULT,
StorageUnit.BYTES);
```
Can you help share some pointers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
