adoroszlai opened a new pull request #2798:
URL: https://github.com/apache/ozone/pull/2798
## What changes were proposed in this pull request?
HDDS-4330 added dependency on `hdds-server-framework` for `ozone-common`.
As far as I see the only reason for the dependency is to be able to use
`NodeDetails` class, which was moved from `ozone-manager` module.
Unfortunately this brings in a lot of unnecessary dependencies for Ozone
Filesystem:
```
| \-
org.apache.ozone:hdds-server-framework:jar:1.2.0-SNAPSHOT:compile (optional)
| +-
org.apache.ozone:hdds-interface-server:jar:1.2.0-SNAPSHOT:compile (optional)
| +-
org.apache.ozone:hdds-hadoop-dependency-server:jar:1.2.0-SNAPSHOT:compile
(optional)
| +- org.rocksdb:rocksdbjni:jar:6.20.3:compile (optional)
| +- io.prometheus:simpleclient_dropwizard:jar:0.7.0:compile
(optional)
| | \- io.prometheus:simpleclient:jar:0.7.0:compile (optional)
| +- io.prometheus:simpleclient_common:jar:0.7.0:compile
(optional)
| \-
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.12.1:compile
(optional)
```
increasing the size of the shaded jars:
```
$ ls -1 -s --block-size=M ozone-filesystem-hadoop*
88M ozone-filesystem-hadoop2-1.2.0-SNAPSHOT.jar
88M ozone-filesystem-hadoop3-1.2.0-SNAPSHOT.jar
$ unzip -t ozone-filesystem-hadoop3-*jar | wc -l
30811
```
Compare those to Ozone 1.1.0:
```
$ ls -1 -s --block-size=M hadoop-ozone-filesystem-hadoop*
41M hadoop-ozone-filesystem-hadoop2-1.1.0.jar
41M hadoop-ozone-filesystem-hadoop3-1.1.0.jar
$ unzip -t hadoop-ozone-filesystem-hadoop3-*jar | wc -l
24460
```
So this PR proposes to move `NodeDetails` to `hdds-common`, which
`ozone-common` already depends on, and get rid of the server-specific
dependency.
https://issues.apache.org/jira/browse/HDDS-5933
## How was this patch tested?
```
$ ls -1 -s --block-size=M ozone-filesystem-hadoop*
47M ozone-filesystem-hadoop2-1.2.0-SNAPSHOT.jar
47M ozone-filesystem-hadoop3-1.2.0-SNAPSHOT.jar
$ unzip -t ozone-filesystem-hadoop3-*jar | wc -l
27498
```
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/1418724556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
