adoroszlai commented on a change in pull request #2810: URL: https://github.com/apache/ozone/pull/2810#discussion_r744975493
########## File path: hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/TestUgiFilter.java ########## @@ -0,0 +1,171 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.s3; + +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; +import javax.servlet.FilterChain; +import javax.servlet.FilterConfig; +import javax.servlet.ServletException; +import java.time.LocalDate; +import java.util.Map; +import java.util.HashMap; +import java.util.Enumeration; +import java.util.Collections; +import java.io.IOException; + +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.s3.signature.*; +import org.apache.hadoop.ozone.s3.exception.OS3Exception; + +import org.apache.hadoop.io.Text; + +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; + +import static org.apache.hadoop.ozone.s3.signature.SignatureProcessor.DATE_FORMATTER; + +/** + * Test class for @{@link UgiFilter}. + */ +public class TestUgiFilter { + + private OzoneConfiguration conf; + private String s3HttpAddr; + private Text omService; + private String curDate; + private Map<String, String> headers; + private Map<String, String[]> parameters; + + private static final String HOST_HEADER = "Host"; + private static final String ENCODE_HEADER = "Accept-Encoding"; + private static final String USER_AGENT_HEADER = "User-Agent"; + private static final String DATE_HEADER = "X-Amz-Date"; + private static final String ENCRYPT_TYPE_HEADER = "X-Amz-Content-SHA256"; + private static final String AUTHORIZATION_HEADER = "Authorization"; + private static final String LENGTH_HEADER = "Content-Length"; + + @Before + public void setup() { + conf = new OzoneConfiguration(); + s3HttpAddr = "localhost:9878"; + conf.set(S3GatewayConfigKeys.OZONE_S3G_HTTP_ADDRESS_KEY, s3HttpAddr); + s3HttpAddr = s3HttpAddr.substring(0, s3HttpAddr.lastIndexOf(":")); + conf.set(S3GatewayConfigKeys.OZONE_S3G_DOMAIN_NAME, s3HttpAddr); + omService = new Text("127.0.0.1:9862"); + LocalDate now = LocalDate.now(); + curDate = DATE_FORMATTER.format(now); + + headers = new HashMap<>(); + parameters = new HashMap<>(); + + headers.put(HOST_HEADER, "localhost:9878"); + headers.put(ENCODE_HEADER, "identity"); + headers.put(USER_AGENT_HEADER, "aws-cli/2.1.29 "+ + "Python/3.8.8 Linux/4.15.0-144-generic "+ + "exe/x86_64.ubuntu.18 prompt/off "+ + "command/s3api.create-bucket"); + headers.put(DATE_HEADER, "20210616T195044Z"); + headers.put(ENCRYPT_TYPE_HEADER, + "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"); + headers.put(AUTHORIZATION_HEADER, "AWS4-HMAC-SHA256 "+ + "Credential=AKIAIIIE56NH5ZHKLTWQ/20210616/us-east-1/s3/aws4_request, "+ + "SignedHeaders=host;x-amz-content-sha256;x-amz-date, "+ + "Signature=c29b4c46e825d5df56cdde12a61adfa65560a54"+ + "7c8973b9809621086727a2f2e"); + headers.put(LENGTH_HEADER, "0"); + + } + + @Test + public void testUgiFilterDoFilter() throws IOException, ServletException { + UgiFilter filter = new UgiFilter(); + filter.setOzoneConfiguration(this.conf); + filter.setOmService(this.omService); + + HttpServletRequest request = Mockito.mock(HttpServletRequest.class); + HttpServletResponse response = Mockito.mock(HttpServletResponse.class); + FilterChain filterChain = Mockito.mock(FilterChain.class); + FilterConfig filterConfig = Mockito.mock(FilterConfig.class); + + // correct date in autherization header for AuthorizationV4QueryParser + // date validator + headers.put(AUTHORIZATION_HEADER, headers. + get(AUTHORIZATION_HEADER).replace("20210616", curDate)); + Enumeration<String> headerNames = Collections.enumeration(headers.keySet()); + + Mockito.when(request.getScheme()).thenReturn("http"); + Mockito.when(request.getMethod()).thenReturn("PUT"); + Mockito.when(request.getPathInfo()).thenReturn("/bucket1"); + Mockito.when(request.getHeaderNames()).thenReturn(headerNames); + Mockito.when(request.getHeader(HOST_HEADER)).thenReturn( + headers.get(HOST_HEADER)); + Mockito.when(request.getHeader(ENCODE_HEADER)).thenReturn( + headers.get(ENCODE_HEADER)); + Mockito.when(request.getHeader(USER_AGENT_HEADER)).thenReturn( + headers.get(USER_AGENT_HEADER)); + Mockito.when(request.getHeader(DATE_HEADER)).thenReturn( + headers.get(DATE_HEADER)); + Mockito.when(request.getHeader(ENCRYPT_TYPE_HEADER)).thenReturn( + headers.get(ENCRYPT_TYPE_HEADER)); + Mockito.when(request.getHeader(AUTHORIZATION_HEADER)).thenReturn( + headers.get(AUTHORIZATION_HEADER)); + Mockito.when(request.getHeader(LENGTH_HEADER)).thenReturn( + headers.get(LENGTH_HEADER)); + Mockito.when(request.getParameterMap()).thenReturn(parameters); + + filter.init(filterConfig); + filter.doFilter(request, response, filterChain); + filter.destroy(); + } Review comment: Can you please help me understand what is being asserted here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
