kerneltime commented on pull request #2817: URL: https://github.com/apache/ozone/pull/2817#issuecomment-965699297
> > > > Adding annotations will not insure that the insertion will occur at the time of invocation of the endpoint without the need to modify each invocation. For now not adding that change. No additional unit tests are needed for signature parsing for now. > > > > > > > > > I think our discussion is to add method level annotation. But this fix will catch issue, we are safe guarded in a way. But I still believe lets have a Jira open to add during method invocation, instead of Object Creation. > > > > > > I do not see an easy way without intercepting the invocation of all the HTTP operations for the annotations to take effect. We can discuss offline but it seems a bit redundant with this change. > > I see one way is adding annotation to each method which handles HTTP requests or use aspectj library which we are discussing offline with @avijayanhwx. But with the proposed fix it is good, we can catch errors. Yeah. I don't think bringing in a whole new library to deal with this is prudent at the moment. The current check with protocol check PR https://github.com/apache/ozone/pull/2822 should be sufficient and straightforward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
