szetszwo commented on a change in pull request #2835:
URL: https://github.com/apache/ozone/pull/2835#discussion_r748195568
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java
##########
@@ -259,6 +268,19 @@ public void write(ByteBuffer b, int off, int len) throws
IOException {
}
final StreamBuffer buf = new StreamBuffer(b, off, len);
+
+ // Controls the number of buffers on the client.
+ if (futures.size() >= streamWindowSize) {
Review comment:
Currently, the buffer is removed only after it is committed. After this
change, the buffer can be removed after it is acked but not yet committed. If
some buffers are removed before commit, the retry won't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
