sodonnel commented on a change in pull request #2849:
URL: https://github.com/apache/ozone/pull/2849#discussion_r752231631
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockOutputStreamEntry.java
##########
@@ -291,8 +297,9 @@ private BlockID underlyingBlockID() {
* futures if false.
* @return
*/
- public boolean checkStreamFailures(boolean forPutBlock) {
+ public List<ECBlockOutputStream> getFailedStreams(boolean forPutBlock) {
final Iterator<ECBlockOutputStream> iter = blockStreams().iterator();
+ List<ECBlockOutputStream> failedStream = new ArrayList<>();
Review comment:
Nit: It would read better if `failedStream` was named `failedStreams` as
it is a list of streams rather than a single stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
