bharatviswa504 commented on a change in pull request #2822:
URL: https://github.com/apache/ozone/pull/2822#discussion_r753602705
##########
File path:
hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/rpc/RpcClientTest.java
##########
@@ -149,7 +149,17 @@
OZONE_OM_CLIENT_PROTOCOL_VERSION,
"1.0.1",
"1.0.1",
- false);;
+ false),
+ VALID_EXPECTED_TWO_OM_ONE_LOWER_VERSION(
+ OZONE_OM_CLIENT_PROTOCOL_VERSION,
+ "1.0.1",
+ "2.0.1",
+ false),
+ VALID_EXPECTED_TWO_OM_ONE_EMPTY(
+ OZONE_OM_CLIENT_PROTOCOL_VERSION,
+ "1.0.1",
Review comment:
Thanks for adding.
Can we have both "", as in the case added "" is not compared, as first
version is lower code returns false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
