umamaheswararao commented on a change in pull request #2848: URL: https://github.com/apache/ozone/pull/2848#discussion_r754518976
########## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedInputStream.java ########## @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.client.io; + +import org.apache.hadoop.hdds.client.BlockID; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.scm.storage.BlockExtendedInputStream; +import org.apache.hadoop.hdds.scm.storage.ByteReaderStrategy; + +import java.io.EOFException; +import java.io.IOException; +import java.nio.ByteBuffer; + +/** + * Input stream which wraps a ECBlockReconstructedStripeInputStream to allow + * a EC Block to be read via the traditional InputStream read methods. + */ +public class ECBlockReconstructedInputStream extends BlockExtendedInputStream { + + private ECReplicationConfig repConfig; + private ECBlockReconstructedStripeInputStream stripeReader; + private ByteBuffer[] bufs; + private boolean closed = false; + + private long position = 0; + + public ECBlockReconstructedInputStream(ECReplicationConfig repConfig, + ECBlockReconstructedStripeInputStream stripeReader) { Review comment: Why do we need to take stripereader from out side. I thought this class will abstract all Stripe reading related. I agree to take as arg if we have plans to plugin different type of impls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
