rakeshadr commented on a change in pull request #2571: URL: https://github.com/apache/ozone/pull/2571#discussion_r754796906
########## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMStartupWithBucketLayout.java ########## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.om; + +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.MiniOzoneCluster; +import org.apache.hadoop.ozone.TestDataUtil; +import org.apache.hadoop.ozone.client.OzoneBucket; +import org.apache.hadoop.ozone.om.helpers.BucketLayout; +import org.junit.Assert; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.Timeout; + +import java.util.UUID; + +/** + * Verifies OM startup with different layout. + */ +public class TestOMStartupWithBucketLayout { + + /** + * Set a timeout for each test. + */ + @Rule + public Timeout timeout = Timeout.seconds(300); + + private static MiniOzoneCluster cluster; + + public static void startClusterWithSimpleLayout() throws Exception { + OzoneConfiguration conf = new OzoneConfiguration(); + String clusterId = UUID.randomUUID().toString(); + String scmId = UUID.randomUUID().toString(); + String omId = UUID.randomUUID().toString(); + conf.set(OMConfigKeys.OZONE_DEFAULT_BUCKET_LAYOUT, + BucketLayout.OBJECT_STORE.name()); + cluster = MiniOzoneCluster.newBuilder(conf).setClusterId(clusterId) + .setScmId(scmId).setOmId(omId).build(); + cluster.waitForClusterToBeReady(); + } + + public static void startClusterWithPrefixLayout() throws Exception { Review comment: @zhengchenyu I think the overall test needs to be organized as we are replacing simple/prefix concept with bucket layout. I am trying to add pseudo code idea info like, _Test case: testRestartWithMultipleLayouts_ cluster = MiniOzoneCluster.newBuilder(conf).withoutDatanodes().build(); cluster.waitForClusterToBeReady(); OzoneBucket bucket1 = TestDataUtil.createVolumeAndBucket(cluster, BucketLayout.FILE_SYSTEM_OPTIMIZED); verifyBucketLayout(bucket1, BucketLayout.FILE_SYSTEM_OPTIMIZED, true); // verify OM default behavior with LEGACY OzoneBucket bucket2 = TestDataUtil.createVolumeAndBucket(cluster, BucketLayout.LEGACY); verifyBucketLayout(bucket2, BucketLayout.OBJECT_STORE, false); OzoneBucket bucket3 = TestDataUtil.createVolumeAndBucket(cluster, BucketLayout.OBJECT_STORE); verifyBucketLayout(bucket3, BucketLayout.OBJECT_STORE, false); // stop cluster cluster.stop(); // update om default buck layout config value to conf.set(OMConfigKeys.OZONE_DEFAULT_BUCKET_LAYOUT, BucketLayout.FILE_SYSTEM_OPTIMIZED.name()); // restart OM with updated config cluster.getOzoneManager().restart(); // verify OM default behavior with LEGACY OzoneBucket bucket4 = TestDataUtil.createVolumeAndBucket(cluster, BucketLayout.LEGACY); verifyBucketLayout(bucket4, BucketLayout.FILE_SYSTEM_OPTIMIZED, true); // verify existing buckets after OM restart. OzoneVolume volume = objectStore.getVolume(volumeName); bucket1 = volume.getBucket(bucket1.getName()); bucket2 = volume.getBucket(bucket2.getName()); bucket3 = volume.getBucket(bucket3.getName()); verifyBucketLayout(bucket1, BucketLayout.FILE_SYSTEM_OPTIMIZED, true); verifyBucketLayout(bucket2, BucketLayout.OBJECT_STORE, false); verifyBucketLayout(bucket3, BucketLayout.OBJECT_STORE, false); -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
