szetszwo commented on a change in pull request #2858:
URL: https://github.com/apache/ozone/pull/2858#discussion_r755632849
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
##########
@@ -157,8 +166,6 @@ public Response put(
@QueryParam("uploadId") @DefaultValue("") String uploadID,
Review comment:
> This is also part of AWS S3 protocol for multipart upload.
@bharatviswa504 , thanks for the info. You are right that partNumber and
uploadId are also in AWS; see
https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPart.html
> Adding query param streaming to this API and then passing query param from
AWS S3 SDK will not be possible ...
It is still better to add a query param and set the default to false
(non-streaming) for now. After streaming is stable, we will change the default
to true. We need this param for testing and branch mark without restarting the
machines. We should set the param name to something like
"internalOzoneParam-streaming" to emphasize that it is not in the AWS S3
protocol.
AWS S3 SDK will always use the default.
We may have a conf to override the default value if such conf is useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
