lokeshj1703 commented on a change in pull request #2704:
URL: https://github.com/apache/ozone/pull/2704#discussion_r758053101
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -736,23 +744,48 @@ public void notifyTermIndexUpdated(long term, long index)
{
return f;
}
+ // Removes the stateMachine data from cache once both followers catch up
+ // to the particular index.
+ private void removeStateMachineDataIfNeeded(long index) {
+ if (waitOnBothFollowers) {
+ LOG.info("Removing data corresponding to log index {} from cache",
+ index);
+ try {
+ RaftServer.Division division =
ratisServer.getServer().getDivision(gid);
+ if (division.getInfo().isLeader() && Arrays
+ .stream(division.getInfo().getFollowerNextIndices())
+ .allMatch(i -> i >= index)) {
+ LOG.debug("Removing data corresponding to log index {} from cache",
+ index);
+ stateMachineDataCache.remove(index);
Review comment:
`Arrays
.stream(division.getInfo().getFollowerNextIndices())
.allMatch(i -> i >= index)`
This condition can be false for some indices. For example
`removeStateMachineDataIfNeeded` is called for every index. It is possible that
next index could be lagging for one follower. As a result condition eviction
would happen for some indexes and not for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
