szetszwo commented on a change in pull request #2860:
URL: https://github.com/apache/ozone/pull/2860#discussion_r758318422
##########
File path:
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto
##########
@@ -451,7 +451,7 @@ RPC */
message PutSmallFileRequestProto {
required PutBlockRequestProto block = 1;
required ChunkInfo chunkInfo = 2;
- required bytes data = 3;
+ optional bytes data = 3;
Review comment:
Yes, changing required to optional is backward compatible since the old
code always provides the value and the new code can handle it.
However, it is not forward compatible since the old code may not be able to
handle the case that the value is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
