sodonnel commented on pull request #2871: URL: https://github.com/apache/ozone/pull/2871#issuecomment-981788389
I think this change looks good, but I am not sure about the new interface name `CopyingReplicationConfig`. I wonder if either `ReplicationConfigWithFactor` or `ReplicatedReplicationConfig` would be better? The EC one will be called ECReplicationConfig, so perhaps ReplicatedReplicationConfig is similar. Having `Copying` in the name immediately made me think the interface was related the copying the ReplicationConfig object, which is not the case at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
