bshashikant commented on a change in pull request #2704:
URL: https://github.com/apache/ozone/pull/2704#discussion_r759168028
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -736,23 +744,48 @@ public void notifyTermIndexUpdated(long term, long index)
{
return f;
}
+ // Removes the stateMachine data from cache once both followers catch up
+ // to the particular index.
+ private void removeStateMachineDataIfNeeded(long index) {
+ if (waitOnBothFollowers) {
+ LOG.info("Removing data corresponding to log index {} from cache",
+ index);
+ try {
+ RaftServer.Division division =
ratisServer.getServer().getDivision(gid);
+ if (division.getInfo().isLeader() && Arrays
+ .stream(division.getInfo().getFollowerNextIndices())
+ .allMatch(i -> i >= index)) {
Review comment:
The idea is to wait for both followers to catch up . How minimum is
useful here?
As soon as both followers catch up, the data will be cleaned up on next
index update/applyTransaction.
There is already an alternative approach addressed with
https://issues.apache.org/jira/browse/RATIS-1441 which changes the majority
index based on the min index and gap threshold.
The idea of this patch is to have all solutions built and then tried out in
a real cluster and see what works best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
