sodonnel commented on a change in pull request #2889: URL: https://github.com/apache/ozone/pull/2889#discussion_r763913179
########## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java ########## @@ -0,0 +1,213 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.client.io; + +import org.apache.hadoop.hdds.client.BlockID; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.scm.XceiverClientFactory; +import org.apache.hadoop.hdds.scm.pipeline.Pipeline; +import org.apache.hadoop.hdds.scm.storage.BlockExtendedInputStream; +import org.apache.hadoop.hdds.scm.storage.ByteReaderStrategy; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.function.Function; + +/** + * Top level class used to read data from EC Encoded blocks. This class decides, + * based on the block availability, whether to use a reconstruction or non + * reconstruction read and also handles errors from the non-reconstruction reads + * failing over to a reconstruction read when they happen. + */ +public class ECBlockInputStreamProxy extends BlockExtendedInputStream { + + private final ECReplicationConfig repConfig; + private final boolean verifyChecksum; + private final XceiverClientFactory xceiverClientFactory; + private final Function<BlockID, Pipeline> refreshFunction; + private final OmKeyLocationInfo blockInfo; + private final ECBlockInputStreamFactory ecBlockInputStreamFactory; + + private BlockExtendedInputStream blockReader; + private boolean reconstructionReader = false; + private List<DatanodeDetails> failedLocations = new ArrayList<>(); + + /** + * Given the ECReplicationConfig and the block length, calculate how many + * data locations the block should have. + * @param repConfig The EC Replication Config + * @param blockLength The length of the data block in bytes + * @return The number of expected data locations + */ Review comment: I believe I changed the ECBlockInputStream to call the static method in the proxy class: ``` protected int calculateExpectedDataBlocks(ECReplicationConfig rConfig) { return ECBlockInputStreamProxy.expectedDataLocations(rConfig, getLength()); } ``` Is the above code you quoted still inplace after this PR goes in? I agree we may want to create a Util class in the future, but for now we just have two shared static methods on the Proxy class, so its perhaps OK to leave them there until we see if there are any more that come up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
