fapifta opened a new pull request #2905: URL: https://github.com/apache/ozone/pull/2905
## What changes were proposed in this pull request? If we are unlucky enough, and we get the same int twice in MultiNodePipelineBlockAllocator#allocateBlock as the number used in the PipelineID, and as the DN's port, then we will have two pseudo DNs in the pipeline that gets the same MockDNStorage assigned. Which means that if we declare that node to fail, we get a secondary failure during failure handling, and the code is not prepared for that as of now, and also we swallow the exception in handleOutputStreamWrite inside ECKeyOutputStream, which we use from the handleStripeFailure method as well as during the regular write. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-6083 ## How was this patch tested? I changed the RAND.nextInt() call in the incriminated method, to RAND.nextInt(4) to ensure there are duplicates, then I was able to reproduce the issue, otherwise it is hard to reproduce it, and I don't know of a better way to test it either, at least none that would worth the effort really. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
