bharatviswa504 commented on a change in pull request #2854:
URL: https://github.com/apache/ozone/pull/2854#discussion_r767037600
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/CloseContainerCommandHandler.java
##########
@@ -78,6 +77,10 @@ public void handle(SCMCommand command, OzoneContainer
ozoneContainer,
((CloseContainerCommand)command).getProto();
final ContainerController controller = ozoneContainer.getController();
final long containerId = closeCommand.getContainerID();
+ if (LOG.isDebugEnabled()) {
Review comment:
I don't think we need isDebugEnabled
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/CloseContainerCommandHandler.java
##########
@@ -78,6 +77,10 @@ public void handle(SCMCommand command, OzoneContainer
ozoneContainer,
((CloseContainerCommand)command).getProto();
final ContainerController controller = ozoneContainer.getController();
final long containerId = closeCommand.getContainerID();
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Processing Close Container command containerID={}",
Review comment:
Minor: space between = or we can use ":" like other places
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/CloseContainerCommandHandler.java
##########
@@ -127,7 +128,9 @@ public void handle(SCMCommand command, OzoneContainer
ozoneContainer,
break;
}
} catch (NotLeaderException e) {
- LOG.debug("Follower cannot close container #{}.", containerId);
+ if (LOG.isDebugEnabled()) {
Review comment:
I don't think we need isDebugEnabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
