smengcl commented on a change in pull request #2900:
URL: https://github.com/apache/ozone/pull/2900#discussion_r766899951
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerGrpc.java
##########
@@ -195,10 +195,10 @@ public void start() throws IOException {
public void stop() {
if (isStarted) {
try {
+ server.shutdown();
Review comment:
Basically this implies triggering server shutdown and readExecutors
shutdown (roughly) simutaneously, rather than awaiting readExecutors shutdown
first then initiate server shutdown? If so I'm +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]