fapifta commented on a change in pull request #2910:
URL: https://github.com/apache/ozone/pull/2910#discussion_r768266436
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java
##########
@@ -124,6 +124,13 @@
tags = ConfigTag.CLIENT)
private boolean checksumVerify = true;
+ @Config(key = "max.ec.stripe.write.retries.on.failures",
Review comment:
I would suggest to either use max.retries for this purpose, or if the
scope of that config is to large and it is better to have a separate config,
name it similarly as for example max.ec.retries, if it makes sense to
distinguish between write and read here then max.ec.write.retries, and only if
we also want to distinguish between stripe write retries and ec key write
retries then probably max.ec.stripe.write.retries. What do you think? I would
definitely remove at least the ".on.failures" part as it is fairly obvious that
retries will happen if there was a failure.
Also I think it should default to the value of max.retries instead of an
arbitrary number.
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockOutputStreamEntry.java
##########
@@ -290,6 +290,14 @@ private BlockID underlyingBlockID() {
return blockOutputStreams[0].getBlockID();
}
+ public List<ECBlockOutputStream> getDataWriteFailedStreams() {
Review comment:
Wouldn't streamsWithWriteFailure() and streamsWithPutBlockFailure() be
better names for these? For me it seems to be easier to get what the actual
result is, but maybe it is just my taste of naming, so I can live with these
names as well.
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -51,6 +51,7 @@
* block output streams chunk by chunk.
*/
public class ECKeyOutputStream extends KeyOutputStream {
+ private final int maxRetriesOnStripeWriteFailures;
Review comment:
I think this instance variable is not necessary, we use it just in one
place, where we can also call config.getMaxECStripeWriteRetries() as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
