JacksonYao287 commented on a change in pull request #2756:
URL: https://github.com/apache/ozone/pull/2756#discussion_r768270855
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/FindTargetGreedy.java
##########
@@ -109,6 +122,7 @@ private void
setConfiguration(ContainerBalancerConfiguration conf) {
@Override
public ContainerMoveSelection findTargetForContainerMove(
DatanodeDetails source, Set<ContainerID> candidateContainers) {
+ sortTargetForSource(source);
Review comment:
after a deep thought, i think we have to sort potentialTargets every
time , even for same source. after a certain target is selected and a move
option is scheduled to it, `sizeEntering` of it will increase, and thus the
utilization will increase. so when choosing a target for even the same source,
if two candidate target has the same network topology distance to the source ,
the priority may change according to current usageinfo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
