adoroszlai commented on a change in pull request #2599:
URL: https://github.com/apache/ozone/pull/2599#discussion_r768608184
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
##########
@@ -241,6 +241,9 @@ public SCMRegisteredResponseProto register(
pipelineReportsProto));
}
try {
+ Preconditions.checkState(registeredCommand.getError()
+ == SCMRegisteredResponseProto.ErrorCode.success,
+ "DataNode has higher Software Layout Version than SCM.");
Review comment:
While this one-liner is elegant from code perspective, I think we should
avoid polluting the audit log with the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
