swagle commented on a change in pull request #2913:
URL: https://github.com/apache/ozone/pull/2913#discussion_r769216167
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##########
@@ -339,6 +339,7 @@ protected void processResult(CommitKeyRequest
commitKeyRequest,
// versioning of keys. So, this can be revisited later.
if (omKeyInfo.getKeyLocationVersions().size() == 1) {
omMetrics.incNumKeys();
+ omMetrics.incDataCommittedBytes(omKeyInfo.getDataSize());
Review comment:
Maybe a separate metric for tracking overwrites? Although overwriting
use case for this particular metric should probably still add to the cumulative
value. Tracking effective committed data accounting for overwrites cannot be
done by metrics system I think, maybe some like Recon can calculate this after
the fact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
