adoroszlai commented on a change in pull request #2498:
URL: https://github.com/apache/ozone/pull/2498#discussion_r774423043
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
##########
@@ -72,13 +72,25 @@
*/
@Config(key = "replication.streams.limit",
type = ConfigType.INT,
- defaultValue = "10",
+ defaultValue = "12",
tags = {DATANODE},
description = "The maximum number of replication commands a single " +
"datanode can execute simultaneously"
)
private int replicationMaxStreams = REPLICATION_MAX_STREAMS_DEFAULT;
+ /**
+ * The maximum number of replication requests.
+ */
+ @Config(key = "replication.queue.limit",
Review comment:
Moving existing config in #2943.
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
##########
@@ -72,13 +72,25 @@
*/
@Config(key = "replication.streams.limit",
type = ConfigType.INT,
- defaultValue = "10",
+ defaultValue = "12",
tags = {DATANODE},
description = "The maximum number of replication commands a single " +
"datanode can execute simultaneously"
)
private int replicationMaxStreams = REPLICATION_MAX_STREAMS_DEFAULT;
+ /**
+ * The maximum number of replication requests.
+ */
+ @Config(key = "replication.queue.limit",
Review comment:
Can you please add this new config to
`ReplicationServer#ReplicationConfig` instead of `DatanodeConfig`? That is a
more specific class for config related to replication. If we also moved
existing `replicationMaxStreams`, too, then we could avoid introducing
`DatanodeConfiguration` in `ReplicationServer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
