JacksonYao287 commented on a change in pull request #2892:
URL: https://github.com/apache/ozone/pull/2892#discussion_r774515869
##########
File path: hadoop-hdds/interface-admin/src/main/proto/ScmAdminProtocol.proto
##########
@@ -479,11 +479,14 @@ message GetContainerTokenResponseProto {
message StartContainerBalancerRequestProto {
optional string traceID = 1;
optional double threshold = 2;
- optional int32 idleiterations = 3;
- optional double maxDatanodesRatioToInvolvePerIteration = 4;
+ optional int32 idleiterations = 3 [deprecated = true];
+ optional double maxDatanodesRatioToInvolvePerIteration = 4 [deprecated =
Review comment:
can we just replace them with the new. Compatibility may be not
considered for now
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java
##########
@@ -47,68 +41,66 @@
public final class ContainerBalancerConfiguration {
private static final Logger LOG =
LoggerFactory.getLogger(ContainerBalancerConfiguration.class);
- private OzoneConfiguration ozoneConfiguration;
@Config(key = "utilization.threshold", type = ConfigType.AUTO, defaultValue =
- "0.1", tags = {ConfigTag.BALANCER},
- description = "Threshold is a fraction in the range of 0 to 1. A " +
+ "10", tags = {ConfigTag.BALANCER},
+ description = "Threshold is a percentage in the range of 0 to 100. A " +
"cluster is considered balanced if for each datanode, the " +
"utilization of the datanode (used space to capacity ratio) differs"
+
" from the utilization of the cluster (used space to capacity ratio"
+
- " of the entire cluster) no more than the threshold value.")
- private String threshold = "0.1";
+ " of the entire cluster) no more than the threshold.")
+ private String threshold = "10";
Review comment:
can we also make threshold int not String?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
