sky76093016 commented on a change in pull request #2949: URL: https://github.com/apache/ozone/pull/2949#discussion_r776276465
########## File path: hadoop-hdds/docs/content/security/SecuringDatanodes.md ########## @@ -38,7 +38,7 @@ that is setup in hdfs-site.xml. Property|Description --------|-------------- dfs.datanode.kerberos.principal|The datanode service principal. <br/> e.g. dn/[email protected] -dfs.datanode.keytab.file| The keytab file used by datanode daemon to login as its service principal. +dfs.datanode.kerberos.keytab.file| The keytab file used by datanode daemon to login as its service principal. Review comment: Thanks to @adoroszlai ’s review, I think the original intention of this [jira](https://issues.apache.org/jira/projects/HDDS/issues/HDDS-6119) is to change `dfs.datanode.keytab.file` to `dfs.datanode.kerberos.keytab.file`, which is similar to naming conventions such as `dfs.datanode.kerberos.principal`. The purpose of this issue is to change its naming for consistency. Do you think this is feasible? If change the naming, the code you mentioned also needs to be changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
