GeorgeJahad opened a new pull request #2961:
URL: https://github.com/apache/ozone/pull/2961
## What changes were proposed in this pull request?
When the OM-HA code was added, the KeyManager tests were not completely
updated. Many of them still call the KeyManager "write-path" methods even
though those methods have been superceded by the HA methods. For this reason
the obsolete methods in the KeyManager class could not be removed.
This PR completes that work and removes the obsolete methods from Keymanager
and KeyManagerImpl classes.
#### Replaced keyManager reference with writeClient reference
Most of the tests were fixed by replacing the keyManager reference to the
obsolete methods. Now, instead of invoking the methods through a keyManager,
they are invoked with a reference to an rpcClient, ("writeClient"). This in
turn invokes the correct OM write path methods, instead of the obsolete
KeyManager ones.
#### OmTestManagers
To facilitate the creation of this "writeClient", I've added the
OmTestManagers class. It creates the writeClient and the Ozone Manager needed
by that client. It also exposes the other OM managers, (bucketManager,
volumeManager, etc,) which are used by the tests. Since OmTestManagers is used
by most of the other classes, it would be good to review that class first.
Most of the changes were fairly straight forword. The most complicated
changes are in TestKeyManagerImpl.java, so it would be good to review those
changes after all the others
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3231
also:
https://issues.apache.org/jira/browse/HDDS-3956
## How was this patch tested?
All tests have been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
