neils-dev commented on a change in pull request #2901: URL: https://github.com/apache/ozone/pull/2901#discussion_r780622720
########## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/GrpcOMFailoverProxyProvider.java ########## @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.om.ha; + +import org.apache.hadoop.hdds.conf.ConfigurationSource; +import org.apache.hadoop.hdds.HddsUtils; +import org.apache.hadoop.io.Text; +import org.apache.hadoop.ozone.OmUtils; +import org.apache.hadoop.ozone.OzoneConsts; +import org.apache.hadoop.ozone.ha.ConfUtils; +import org.apache.hadoop.ozone.om.OMConfigKeys; +import org.apache.hadoop.ozone.om.protocolPB.GrpcOmTransport; +import org.apache.hadoop.security.UserGroupInformation; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.OptionalInt; + +import static org.apache.hadoop.hdds.HddsUtils.getHostNameFromConfigKeys; +import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_ADDRESS_KEY; + +/** + * The Grpc s3gateway om transport failover proxy provider implementation + * extending the ozone client OM failover proxy provider. This implmentation + * allows the Grpc OMTransport reuse OM failover retry policies and + * getRetryAction methods. In case of OM failover, client can try + * connecting to another OM node from the list of proxies. + */ +public class GrpcOMFailoverProxyProvider<T> extends + OMFailoverProxyProvider<T> { + + private Map<String, String> omAddresses; + + public GrpcOMFailoverProxyProvider(ConfigurationSource configuration, + UserGroupInformation ugi, + String omServiceId, + Class<T> protocol) throws IOException { + super(configuration, ugi, omServiceId, protocol); + } + + @Override + protected void loadOMClientConfigs(ConfigurationSource config, String omSvcId) + throws IOException { + Map omProxies = new HashMap<>(); Review comment: Renamed fields for data structures used in base class : omProxiesNodeIdKeyset (as we need to set the node ids which are the keys for the base class omProxies data structure). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
