sodonnel commented on a change in pull request #2973:
URL: https://github.com/apache/ozone/pull/2973#discussion_r782055479
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockOutputStreamEntryPool.java
##########
@@ -55,6 +55,9 @@ public ECBlockOutputStreamEntryPool(OzoneClientConfig config,
isMultipart, info, unsafeByteBufferConversion, xceiverClientFactory,
openID);
assert replicationConfig instanceof ECReplicationConfig;
+ getExcludeList()
Review comment:
See my earlier comment, which may allow us to get rid of the background
thread.
However if we need to keep the thread, I think the responsibility for
starting the thread should be internal to the ExcludeList class, rather than
having to ensure the user of the class needs to know about it, and start it.
Should we not make ExcludeList start its own thread via its constructor or on
first use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
