neils-dev commented on pull request #2977: URL: https://github.com/apache/ozone/pull/2977#issuecomment-1011420553
Thanks @GeorgeJahad, I like the idea, however there are things shown in the diffs generated that are incorrect, also missing changes ie. OzoneClientProto. It does give a good reference to some of the changes. This is linked to PR #2945. and was asked for there, so a better idea of the changes are seen in that PR (excluding the TLS). In that PR the hrpc changes (HDDS-5581) are 'patched' into the 4440-feature-branch and clearer to see the integration between the feature branch and the 5581. Basically, this PR is a merge from the master into the feature branch. As a result some changes were necessary to the already reviewed s3gateway gRPC code in the feature branch. No additional code was added as the TLS code (2945) will be added to this merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
