kerneltime commented on pull request #2989: URL: https://github.com/apache/ozone/pull/2989#issuecomment-1016075709
Thanks @adoroszlai for the review and catching the version for the annotation. I updated the tests and ran them multiple times to make sure they are not flaky. This should result in no increase in overall test time and test the intended code path. As long as the container that the objects were initially flushed to, is moved to state other than open, the retry logic kicks in to find a different pipeline and complete the write and flush. Thus, expecting a count of 2 for the number of locations seems valid. Before the fix if the exception raised was inherited from `IOException` the retry logic would not kick in and the `flush()`/`close()` would fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
