guihecheng commented on a change in pull request #3000:
URL: https://github.com/apache/ozone/pull/3000#discussion_r787705250
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/GrpcReplicationClient.java
##########
@@ -161,6 +161,9 @@ public void onNext(CopyContainerResponseProto chunk) {
try {
chunk.getData().writeTo(stream);
} catch (IOException e) {
+ LOG.error("Failed to write the stream buffer to {} for container {}",
+ outputPath, containerId, e);
+ deleteOutputOnFailure();
Review comment:
IMO, the original LOG msg is better, because by looking at the JIRA
descriptions, actually the download via network is successful, the failure
happens at sync the downloaded data into the on-disk file.
So we don't call onError() here which should be called on network transfer
faliures, and it may not be a good style to call an overrided method in
another(onError in onNext here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
