kerneltime commented on pull request #2963: URL: https://github.com/apache/ozone/pull/2963#issuecomment-1016994616
1. We do need to serialize FCR and ICR on a per DN basis at the SCM. Since the HB threads on the DN sends one at a time, serializing them on a per DN basis on SCM should be sufficient. 2. Let me think about what you said about serializing and discarding ICR at the time of generating FCR vs. at the time of sending the HB (this PR). SCM would need to know if should process ICR first or FCR when a HB contains both. If we discard at the time or reporting, the HB will only contain FCR. Overall the difference between FCR and ICR is the knowledge that missing containers can be computed on the SCM and to insure SCM has all the containers. Having 2 completely different code paths for reporting on the same entity and then trying to synchronize them for correctly might not be the best approach. We essentially need a stream of containers for which we send reports to SCM. Periodically that stream should include all containers and one of the reports to SCM should have a flag to indicate that all containers have been reported.. this should simplify the report generation, publishing and consuming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
