hanishakoneru commented on a change in pull request #2992:
URL: https://github.com/apache/ozone/pull/2992#discussion_r789158064
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAInvocationHandler.java
##########
@@ -88,7 +88,9 @@ private Object invokeLocal(Method method, Object[] args)
*/
private Object invokeRatis(Method method, Object[] args)
throws Exception {
- long startTime = Time.monotonicNowNanos();
+ LOG.trace("Invoking method {} on target {}", method, ratisHandler);
+ // If we do want to track time taken by ratis,
+ // it should be done via a metric and not via Info logging.
Review comment:
Thanks @sky76093016.
In the comment, can you add a TODO so that it can be tracked.
Something like this:
> // TODO: Add metric here to track time taken by Ratis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
