neils-dev commented on a change in pull request #2901:
URL: https://github.com/apache/ozone/pull/2901#discussion_r789292162
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OMFailoverProxyProvider.java
##########
@@ -552,5 +552,22 @@ protected void setProxiesForTesting(
this.omProxyInfos = testOMProxyInfos;
this.omNodeIDList = testOMNodeIDList;
}
+
+ protected void setOmProxies(Map omProxies) {
+ this.omProxies = omProxies;
+ }
+
+ protected void setOmProxyInfos(Map omProxyInfos) {
+ this.omProxyInfos = omProxyInfos;
+ }
+
+ protected void setOmNodeIDList(List omNodeIDList) {
+ this.omNodeIDList = omNodeIDList;
+ }
Review comment:
See comments above for the Map data structures and related. The
`loadOMClientConfigs` method needed to be overridden in the
`GrpcFailoverProxyProvider` subclass so to not initialize the `omProxyInfos`
and omProxies parent classes with values not applicable to the Grpc failover
(causes errors). With the overridden method the parent class `omProxyInfos`
and `omProxies` Map data structures are initialized with valid key sets that
are necessary for `OmFailoverProxyProvider` methods used by the Grpc failover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
