sodonnel commented on a change in pull request #2990:
URL: https://github.com/apache/ozone/pull/2990#discussion_r791751049



##########
File path: 
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientUtils.java
##########
@@ -64,4 +69,38 @@ public static BucketLayout 
resolveLinkBucketLayout(OzoneBucket bucket,
     }
     return bucket.getBucketLayout();
   }
+
+  public static ReplicationConfig validateAndGetClientReplicationConfig(

Review comment:
       Should we have a unit test for the logic in this method, as there are 
quite a few IF statements etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to