adoroszlai commented on pull request #2974: URL: https://github.com/apache/ozone/pull/2974#issuecomment-1021525442
Thanks @GeorgeJahad for the review. > ``` > ~/incoming/build-master/dev-support/ci -> bats dev-support/ci/selective_ci_checks.bats > bats: /home/gbj/incoming/build-master/dev-support/ci/bats-support/load.bash.bash does not exist > ``` I think that behavior is specific to old versions of Bats (pre-1.2.1). > This comment confused me for a while, because it emphasizes the ozone-runner image: > > _ozone-runner image version is defined in hadoop-ozone/dist/pom.xml. Changing it triggers a complete CI run, although it does not affect unit or integration tests in any way. Actually, hadoop-ozone/dist does not have any Java code, as it assembles other modules after build. So we can skip all Java-specific checks._ > > I would have left the ozone-runner out of it. I made the comment that way because it was a recent runner image version number bump that had started me on this change. Initially I wanted to extract the version number to a properties file. Only later did I realize that we can skip java checks for the entire submodule. Sorry for the confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
