[ 
https://issues.apache.org/jira/browse/HDDS-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483245#comment-17483245
 ] 

Stephen O'Donnell commented on HDDS-6232:
-----------------------------------------

Also, for key -put, there is no mention of the format to specify the EC 
replication in:
{code:java}

ozone sh key put [-hV] [-r=<replication>] [-t=<replicationType>] <value>
                        <fileName>
creates or overwrites an existing key
      <value>      URI of the volume/bucket/key.
                   Ozone URI could start with o3:// or without prefix. URI may
                     contain the host/serviceId and port of the OM server. Both
                     are optional. If they are not specified it will be
                     identified from the config files.
      <fileName>   File to upload
  -h, --help       Show this help message and exit.
  -r, --replication=<replication>
                   Replication configuration of the new key. (this is
                     replication specific. for RATIS/STANDALONE you can use ONE
                     or THREE) Default is specified in the cluster-wide config.
  -t, --type=<replicationType>
                   Replication type of the new key. (use RATIS or STAND_ALONE
                     or EC) Default is specified in the cluster-wide config.
  -V, --version    Print version information and exit. {code}
 

> EC: Bucket create replication help text is incorrect
> ----------------------------------------------------
>
>                 Key: HDDS-6232
>                 URL: https://issues.apache.org/jira/browse/HDDS-6232
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: Ozone CLI
>            Reporter: Stephen O'Donnell
>            Priority: Major
>
> The help for the "ozone sh bucket create" command does not align with the 
> validation:
> {code:java}
> $ ozone sh bucket create -h         
> Usage: ozone sh bucket create [-ghV] [-k=<bekName>] [-l=<allowedBucketLayout>]
>                               [--namespace-quota=<quotaInNamespace>]
>                               [--quota=<quotaInBytes>] [-r=<replication>]
>                               [-t=<replicationType>] [-u=<ownerName>] <value>
> creates a bucket in a given volume
>       <value>              URI of the volume/bucket.
>                            Ozone URI could start with o3:// or without prefix.
>                              URI may contain the host/serviceId and port of 
> the
>                              OM server. Both are optional. If they are not
>                              specified it will be identified from the config
>                              files.
>   -g, --enforcegdpr        if true, indicates GDPR enforced bucket,
>                              false/unspecified indicates otherwise
>   -h, --help               Show this help message and exit.
>   -k, --bucketkey=<bekName>
>                            bucket encryption key name
>   -l, --layout=<allowedBucketLayout>
>                            Allowed Bucket Layouts: FILE_SYSTEM_OPTIMIZED,
>                              OBJECT_STORE
>       --namespace-quota=<quotaInNamespace>
>                            For volume this parameter represents the number of
>                              buckets, and for buckets represents the number of
>                              keys (eg. 5)
>       --quota, --space-quota=<quotaInBytes>
>                            The maximum space quota can be used (eg. 1GB)
>   -r, --replication=<replication>
>                            Replication value. Example: 3 (for Ratis type) or 1
>                              ( for standalone type). In the case of EC, pass
>                              DATA-PARITY, eg 3-2, 6-3, 10-4
>   -t, --type=<replicationType>
>                            Replication type. Supported types are RATIS,
>                              STANDALONE, EC
>   -u, --user=<ownerName>   Owner of the bucket. Defaults to current user if 
> not
>                              specified
>   -V, --version            Print version information and exit.
> bash-4.2$ ozone sh bucket create -t EC -r 3-2 /vol1/ec
> EC replication config should be defined in the form rs-3-2-1024k, 
> rs-6-3-1024; or rs-10-4-1024k.Provided configuration was: 3-2{code}
> Note it says "In the case of EC, pass DATA-PARITY, eg 3-2, 6-3, 10-4"
> However passing that gives an error. You need to pass "rs-3-2-1024k".
> We need to either fix the help text, or make the validation more flexible to 
> default to RS and 1024k if they are not in the string.
> There is also a missing space in the error:
> "... or rs-10-4-1024k.Provided configuration was: 3-2"



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to