adoroszlai commented on a change in pull request #2917:
URL: https://github.com/apache/ozone/pull/2917#discussion_r793977007
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
##########
@@ -61,8 +61,9 @@
private String tableName;
@CommandLine.Option(names = {"--with-keys"},
+ required = true,
Review comment:
My 2 cents: I don't think boolean flags should ever be required, as they
only have two possible values. Usually they should default to `false`
(assuming the variable that gets set matches their wording), so that you only
have to specify it if you want to set it to `true`. If we want the default
behavior to be including keys in output, the flag would better be worded as
`--omit-keys`. Default value would be `true` if the variable is still
`withKeys`, or `false` if the variable is renamed and its usage flipped (`if
(withKeys)` -> `if (!omitKeys)`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
