rakeshadr edited a comment on pull request #3004:
URL: https://github.com/apache/ozone/pull/3004#issuecomment-1024154901
@errose28 thanks for reviewing this PR.
> Let me know what the current requirements for FSO client interactions are
and we can decide whether this is the best way to handle them.
Following is the requirement of FSO feature:
**OM Pre-finalized state**
*Client CreateBucket behavior in different client end points:*
```
[A] Ozone Shell Command #createBucket:-
case-1) New-Shell-Client uses default value OBS:
"ozone sh create bucket myBucket"
Now, ozone client will send the default value OBS to OM server
case-2) New-Shell-Client sends explicit value:
"ozone sh create bucket --layout=FSO myFSOBucket"
[B] BasicRootedFileSystem #createBucket:-
case-3) if the bucket doesn’t exists then ozone client will create a
bucket with "FSO" layout.
```
IIUC the simplest option is to handle it by ignoring the bucket layout
argument at the OM side and silently creates LEGACY bucket layout with a WARN
message.
On a second thought, I was trying an approach to throw exception if user
explicitly specify FSO or OBS layout value in the above mentioned "case-2". But
I like your idea of unifying the pre-finalized code for upcoming features. That
makes code more maintainable. Since this is a new feature, we have the
flexibility to decide the behavior of different FSO cases.
I agree to pause this PR now and would like to see HDDS-6213 proposal patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
