adoroszlai opened a new pull request #3028: URL: https://github.com/apache/ozone/pull/3028
## What changes were proposed in this pull request? Remove intermittent `testRocksDBKeyMayExistApi`, which was an "integration" test checking if RocksDB `keyMayExist` call is cheaper than `get` call for the same key. There are several problems with it: * No warmup, so order matters. (Adding warmup reduces time of both calls.) * Same key names are used for both `get` and `keyMayExist` calls, the result of get might be cached at RocksDB level. (This should help `keyMayExist` due to current order. Reordering the loops indicates that `keyMayExist` takes longer than `get`.) * Too few measurements, no check of whether the difference is statistically significant. * Tests a completely empty database (does not match real life usage) * Measured time includes `getBytesUtf16` calls, not only the RocksDB call being tested. A real JMH-based microbenchmark would be better for that purpose. https://issues.apache.org/jira/browse/HDDS-2919 ## How was this patch tested? https://github.com/adoroszlai/hadoop-ozone/actions/runs/1768566838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
