kaijchen commented on a change in pull request #2996:
URL: https://github.com/apache/ozone/pull/2996#discussion_r803669098
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
##########
@@ -94,6 +113,15 @@ public Void call() throws Exception {
contentGenerator = new ContentGenerator(keySize, bufferSize);
metadata = new HashMap<>();
+ if (spec.commandLine().getParseResult().hasMatchedOption("--factor")) {
+ replicationConfig = ReplicationConfig
+ .fromTypeAndFactor(ReplicationType.RATIS, factor);
+ } else {
+ replicationConfig = OzoneClientUtils
+ .validateAndGetClientReplicationConfig(replicationType, replication,
+ ozoneConfiguration);
+ }
Review comment:
It will be meaningless to only setting `replication` or `type` only.
And it is possible to set `--type EC` with `--replication THREE` together.
| type/replication | THREE | rs-3-2-1024k |
| --- | --- | --- |
| RATIS | OK | Bad |
| EC | Bad | OK |
Should we bind this two options together like `RATIS/THREE` or
`EC/rs-3-2-1024k` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
