smengcl commented on a change in pull request #3061:
URL: https://github.com/apache/ozone/pull/3061#discussion_r804150246
##########
File path: dev-support/ci/selective_ci_checks.bats
##########
@@ -99,6 +99,39 @@ load bats-assert/load.bash
assert_output -p needs-kubernetes-tests=false
}
+@test "integration and unit: script change" {
+ run dev-support/ci/selective_ci_checks.sh c6850484f
Review comment:
> So if we passed the list of changed files to this function, what would
be its remaining job?
Yes you are right. I should have said "feed the file paths directly to the
script" rather than saying "feed the file paths to `get_changed_files()`".
Is `get_changed_files()` called anywhere else? I can only find it called
inside the script itself so far.
> I think it's better to exercise it end-to-end by passing SHAs in the test,
too.
I'm ok with this. I don't have a strong opinion. The discussion is merely
out of my curiosity (and probably my lack of further understanding as well at
this stage). I'm sure there is a good reason for it.
Anyway I am +1 on the patch itself. Thanks again for improving the run times!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
