rakeshadr commented on a change in pull request #3077:
URL: https://github.com/apache/ozone/pull/3077#discussion_r805526298
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
##########
@@ -149,7 +149,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
} else {
omBucketInfo = OmBucketInfo.getFromProtobuf(bucketInfo);
}
-
+ if (omBucketInfo.getBucketLayout().isFileSystemOptimized()) {
+ omMetrics.incNumFSOBucketCreates();
+ }
Review comment:
@ayushtkn @JyotinderSingh
```
if (bucketInfo.getBucketLayout() == null)
// sets to defaultValue. Here it can be OBS or FSO.
} else {
omBucketInfo = OmBucketInfo.getFromProtobuf(bucketInfo);
}
```
Since there is already an explicit `null` check
[OMBucketCreateRequest.java#L142](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java#L142)
to safeguard NPE, I think it won't be null in any case and additional null
check is not required, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
