[
https://issues.apache.org/jira/browse/HDDS-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyao Meng updated HDDS-6339:
-----------------------------
Description:
Before Multi-Tenancy, kerberosID sematically equals accessId in the Ozone code
base.
With Multi-Tenancy, kerberosID is decoupled from accessId meaning they are no
longer equivalent at all times.
Suggestion:
1. Check and rename all code occurrences of {{kerberosID}} to {{accessId}}
wherever appropriate. e.g.
https://github.com/apache/ozone/blob/edcb2e19278b331563187217533935d93660a53e/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManagerImpl.java#L60;
2. Check and rename all protobuf messages occurrences of {{kerberosID}} to
{{accessId}} -- but this might have wire compatibility consequences (not sure
if protobuf would allow it if it is just a name change. the sequence number and
type stays the same). If so, add a comment saying the field is effectively
{{accessId}}. e.g.
https://github.com/apache/ozone/blob/2e6754f6cc0f077ee6738ca76820ac7c6db391ef/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto#L1386
was:
Before Multi-Tenancy, kerberosID sematically equals accessId in the Ozone code
base.
With Multi-Tenancy, kerberosID is decoupled from accessId meaning they are no
longer equivalent at all times.
Suggestion:
1. Check and rename all code occurrences of {{kerberosID}} to {{accessId}}
wherever appropriate. e.g.
https://github.com/apache/ozone/blob/edcb2e19278b331563187217533935d93660a53e/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManagerImpl.java#L60;
2. Check and rename all protobuf messages occurrences of {{kerberosID}} to
{{accessId}} -- but this might have wire compatibility consequences. If so, add
a comment saying the field is effectively {{accessId}}. e.g.
https://github.com/apache/ozone/blob/2e6754f6cc0f077ee6738ca76820ac7c6db391ef/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto#L1386
> Rename kerberosID to accessId in the code and proto messages
> ------------------------------------------------------------
>
> Key: HDDS-6339
> URL: https://issues.apache.org/jira/browse/HDDS-6339
> Project: Apache Ozone
> Issue Type: Task
> Reporter: Siyao Meng
> Priority: Major
>
> Before Multi-Tenancy, kerberosID sematically equals accessId in the Ozone
> code base.
> With Multi-Tenancy, kerberosID is decoupled from accessId meaning they are no
> longer equivalent at all times.
> Suggestion:
> 1. Check and rename all code occurrences of {{kerberosID}} to {{accessId}}
> wherever appropriate. e.g.
> https://github.com/apache/ozone/blob/edcb2e19278b331563187217533935d93660a53e/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManagerImpl.java#L60;
> 2. Check and rename all protobuf messages occurrences of {{kerberosID}} to
> {{accessId}} -- but this might have wire compatibility consequences (not sure
> if protobuf would allow it if it is just a name change. the sequence number
> and type stays the same). If so, add a comment saying the field is
> effectively {{accessId}}. e.g.
> https://github.com/apache/ozone/blob/2e6754f6cc0f077ee6738ca76820ac7c6db391ef/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto#L1386
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
