smengcl commented on a change in pull request #3106:
URL: https://github.com/apache/ozone/pull/3106#discussion_r809375458
##########
File path: hadoop-ozone/dist/src/main/compose/upgrade/testlib.sh
##########
@@ -94,8 +94,8 @@ run_test() {
RESULT=1
fi
- generate_report 'upgrade' "$RESULT_DIR"
copy_results "$test_subdir" "$ALL_RESULT_DIR"
+ generate_report 'upgrade' "$RESULT_DIR"
Review comment:
I think that is indeed redundant at the moment. But I recall @errose28
mentioning in the future we would need to have a matrix to run different set of
versions. Something like:
```
run_test non-rolling-upgrade 1.1.0 1.2.0
run_test non-rolling-upgrade 1.1.0 1.3.0
run_test non-rolling-upgrade 1.2.0 1.3.0
```
In this case we might still need the `generate_report` in `run_test`,
depending on where the XML files are written to. But it looks to me
`copy_results` alone is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
