fapifta commented on pull request #3046: URL: https://github.com/apache/ozone/pull/3046#issuecomment-1043535786
HI @umamaheswararao thank you for taking this one on. As I went through the changes I have run into a few things that turned out to be something that I don't like in the original implementation either. I believe it is good to keep this as close to the hadoop implementation as possible, so I think we are fine. I haven't gone through it line by line, but in general things look good, tests seems to be reasonably adjusted as well. LGTM, +!. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
