sodonnel commented on a change in pull request #3111:
URL: https://github.com/apache/ozone/pull/3111#discussion_r810519421
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/read/TestECBlockInputStream.java
##########
@@ -416,6 +416,7 @@ private void validateBufferContents(ByteBuffer buf, int
from, int to,
return blockStreams;
}
+ // Not a thread safe create.
Review comment:
Should we just make this factory's methods synchronized too? I don't
think it can do any harm, and it may avoid some hard to track down bug in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
