JyotinderSingh commented on a change in pull request #3109:
URL: https://github.com/apache/ozone/pull/3109#discussion_r811572196



##########
File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFSWithObjectStoreCreate.java
##########
@@ -293,13 +290,15 @@ public void 
testMPUFailDuetoDirectoryCreationBeforeComplete()
     Arrays.fill(b, (byte)96);
     ozoneOutputStream.write(b);
 
+    // Need to close ozoneOutputStream before creating directory.
+    // S3MultipartUploadCommitPartRequestWithFSO#getOpenKey makes an
+    // OMFileRequest#getParentID call - which will fail due to existing
+    // directory.
+    ozoneOutputStream.close();
+

Review comment:
       we now need to close the `ozoneOutputStream` before creating new 
directories, I have mentioned the reason in the code comment. This is a 
behavior change in the test, could you please review this @rakeshadr?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to